Data product framework support #2485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This was referenced Jan 17, 2024
Remove unused code
Fix mistake in built-in Python autocoder types
Add _m prefix
Don't fail an assertion on bad serial input
Revise handling of serialize status
timcanham
requested changes
Feb 15, 2024
timcanham
approved these changes
Feb 15, 2024
|
@bocchino I would like you to answer to @timcanham's questions and tell me if we should defer and merge, or update and merge |
|
Will merge for now, comments can be addressed in a follow-up. |
This was referenced Feb 26, 2024
Merged
LeStarch
pushed a commit
that referenced
this pull request
Mar 1, 2024
* Pull in changes to Dp from data-products branch * Revise DpContainer * Address review comments * Revise DpContainer header Use FwSizeStore type to serialize size values * Revise serialization of size type * Revise FpConfig Temporarily change type settings, for testing * Revert change to type config * Revise comment * Add explicit cast to suppress compiler warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following support for data products to the F Prime framework:
The next step is to add the data product support components in Svc.