Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include member array size in dictionary #2165

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

Kronos3
Copy link
Contributor

@Kronos3 Kronos3 commented Aug 1, 2023

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Adds the member array size in dictionary serializable member

Rationale

When you have a struct with an array member:

struct Test {
   a_member: F32,
   another_member: [4] F32
}

The another_member is encoded the same as a_member since the array size is ignored.

This adds a size attribute when relevant.

Future Work

  • Does a schema need to be changed somewhere?
  • Should we do this with a pseudo array in the dictionary?

@Kronos3 Kronos3 changed the title Include member array size in output dictionary Include member array size in dictionary Aug 1, 2023
@LeStarch LeStarch merged commit 2cab871 into nasa:devel Aug 1, 2023
23 checks passed
@Kronos3 Kronos3 deleted the tumbar-member-size branch August 1, 2023 21:16
thomas-bc added a commit that referenced this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants