Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FPP syntax in HelloWorld docs #1985

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Conversation

sobkulir
Copy link
Contributor

Originating Project/Creator JPL Fprime
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n) n/a
Builds Without Errors (y/n) n/a
Unit Tests Pass (y/n) n/a
Documentation Included (y/n) y

Change Description

When trying to build the HelloWorld project, I ran into an error when executing fprime-util impl because the docs contained a syntax error.

Rationale

Make the HelloWorld fpp example buildable out-of-box.

Testing/Review Recommendations

I ran fprime-util impl without problems after my change. Altough fpp-check didn't pass:

user@tpad:/app/MyComponents/HelloWorld$ fpp-check < HelloWorld.fpp
fpp-check
stdin: 41.9
        time get port timeCaller
        ^
error: undefined symbol Fw

I'm very new to fprime so I'm not sure if this is relevant.

Future Work

@sobkulir sobkulir changed the title Fix post annotations in HelloWorld docs Fix FPP syntax in HelloWorld docs Apr 25, 2023
Copy link
Collaborator

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct, there seem to be a syntax error. Thank you for contributing!

@thomas-bc thomas-bc merged commit bcaa558 into nasa:devel Apr 26, 2023
Boehm-Michael pushed a commit to Boehm-Michael/fprime that referenced this pull request Jun 22, 2023
thomas-bc added a commit that referenced this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants