Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing headers and removed where not needed #1572

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

SMorettini
Copy link
Contributor

Originating Project/Creator
Affected Component config
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Two configuration files were missing the inclusion of a header and another one was including a header not needed.

Rationale

Code improvements. It removes some static check warnings.

Testing/Review Recommendations

N/A

Future Work

N/A

@SMorettini SMorettini changed the base branch from master to devel July 19, 2022 13:14
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me!

@LeStarch
Copy link
Collaborator

LeStarch commented Jul 25, 2022

Pre-CI Checks: Must perform before launching CI

  • No obviously malicious code introduced
  • PR is against devel. Use Edit -> change branch to fix, or close PR.

Code Review

  • Code follows flight software quality guidelines
  • Changes are of reasonable length for review

Procedural Checks

  • PR passes CI
  • Accept with squash-and-merge

@LeStarch LeStarch merged commit 60334b1 into nasa:devel Jul 25, 2022
@SMorettini SMorettini deleted the fix-includes-in-config-files branch July 27, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants