Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small corrections #1079

Merged
merged 3 commits into from
Oct 14, 2021
Merged

small corrections #1079

merged 3 commits into from
Oct 14, 2021

Conversation

shubham-shahh
Copy link
Contributor

@shubham-shahh shubham-shahh commented Oct 10, 2021 •
edited
Loading

v2.0.0 PR
Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

corrected grammatical and spelling errors

Rationale

To improve overall readability of the code

Testing/Review Recommendations

Doesn't affect code execution

Future Work

N/A

@shubham-shahh
Copy link
Contributor Author

@LeStarch can you please review it?

LeStarch
LeStarch approved these changes Oct 14, 2021
View reviewed changes
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@shubham-shahh
Copy link
Contributor Author

Hi @LeStarch, The PR is complete, are you planning to merge it?

@LeStarch LeStarch merged commit 37b4bfe into nasa:devel Oct 14, 2021
@LeStarch
Copy link
Collaborator

I needed to let CI run.

@LeStarch
Copy link
Collaborator

Thanks for sending this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeStarch LeStarch LeStarch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shubham-shahh @LeStarch