Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FramingProtocol Use of U8 vs char #2465

Closed
LeStarch opened this issue Jan 4, 2024 Discussed in #2405 · 0 comments · Fixed by #2471
Closed

FramingProtocol Use of U8 vs char #2465

LeStarch opened this issue Jan 4, 2024 Discussed in #2405 · 0 comments · Fixed by #2471
Labels
Refactoring / Code Clarity Code clarity refactoring to ensure the code is highly-maintainable.

Comments

@LeStarch
Copy link
Collaborator

LeStarch commented Jan 4, 2024

Discussed in #2405

Originally posted by VR314 December 1, 2023
In the validate function of the FprimeProtocol.cpp file, the variables byte, calc, and sent of type char when ring.peek is defined to return a U8 and so does the hashBuffer. Why was this done and is there a possibility for issues coming up because of the signedness of the values?
@LeStarch LeStarch added the Refactoring / Code Clarity Code clarity refactoring to ensure the code is highly-maintainable. label Jan 4, 2024
japrozs added a commit to japrozs/fprime that referenced this issue Jan 7, 2024
@japrozs
(nasa#2465) use u8 instead of char
788ac37
@japrozs japrozs mentioned this issue Jan 7, 2024
Merged
@LeStarch LeStarch linked a pull request Jan 8, 2024 that will close this issue
(#2465) use u8 instead of char #2471
Merged
LeStarch pushed a commit that referenced this issue Jan 8, 2024
@japrozs
(#2465) use u8 instead of char (#2471)
bf81b68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Refactoring / Code Clarity Code clarity refactoring to ensure the code is highly-maintainable.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(#2465) use u8 instead of char japrozs/fprime
1 participant
@LeStarch