Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Displayable Types #494

Merged
merged 19 commits into from
Aug 26, 2024
Merged

Add Displayable Types #494

merged 19 commits into from
Aug 26, 2024

Conversation

jwest115
Copy link
Collaborator

@jwest115 jwest115 commented Aug 14, 2024

  • Define displayable types in FPP spec
  • Add isDisplayable to Type trait. Update FPP types to override isDisplayable based on whether the type is displayable or not
  • Update Command, Event, TlmChannel, and Param semantics to check whether each contains displayable types (if not, throw and InvalidType error)
  • Add unit tests to fpp-check

Closes #236.

@bocchino bocchino marked this pull request as ready for review August 22, 2024 21:22
@bocchino bocchino self-requested a review August 22, 2024 21:22
Copy link
Collaborator

@bocchino bocchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I made some revisions to the User's Guide. I added some semantic tests for displayable types, and I added some more error reporting for tracing through type definitions for non-displayable types.

@jwest115 jwest115 merged commit 3ebe028 into nasa:main Aug 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require displayable types in the ground interface
2 participants