Fix initialization of Expires in WP Request #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logic was using DateTime.MaxValue which could establish a value that is later adjusted for time zone. DateTimeOffset.MaxValue is already set to UTC which is the default for DateTimeOffset. Additional problem was in Engine.cs - there are a couple of of commands that are used in the test harness that need to be declared as public so they can be tested. Added some comments in PortSerialManager.cs about the possibility of eating non-serial problems in the try/catch block. Fix #742
josesimoes
reviewed
May 8, 2021
| @@ -611,7 +611,7 @@ private bool CheckValidNanoFrameworkSerialDevice(NanoDevice<NanoSerialDevice> de | |||
| } | |||
| } | |||
| } | |||
| catch | |||
| catch (Exception /* ex */) // we could eat simple programming errors here - like a bad cast or other problem when changing code | |||
There was a problem hiding this comment.
Your comment is correct, of course!
This was (is) here because of the bad things always happening when we where using the UWP APIs.
Probably needs to be revisited now that we aren't using that anymore.
I'm no big fan of "catch all" like this one, but sometimes that's the way to go...
josesimoes
approved these changes
May 8, 2021
josesimoes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Logic was using DateTime.MaxValue which could establish a value that is later adjusted for time zone. DateTimeOffset.MaxValue is already set to UTC which is the default for DateTimeOffset.
Additional problem was in Engine.cs - there are a couple of of commands that are used in the test harness that need to be declared as public so they can be tested.
Added some comments in PortSerialManager.cs about the possibility of eating non-serial problems in the try/catch block.
Motivation and Context
How Has This Been Tested?
Tested using the Serial Test App WPF project that is in the nf-debugger repository and is part of the nanoFramework.Tools.Debugger solution file.
Screenshots
Types of changes
Checklist: