Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace WinRT components access #224

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Replace WinRT components access #224

merged 1 commit into from
Mar 3, 2020

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Mar 3, 2020 •
edited
Loading

Description

  • Moved to official Microsoft.Windows.SDK.Contracts.
  • Upgrade projects to package.reference.
  • Bump version to 1.10.0-preview.
  • Replace nuget pack tasks in Azure yaml.

Motivation and Context

How Has This Been Tested?

  • WPF test app.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes jose.simoes@eclo.solutions

@nfbot
Copy link
Member

nfbot commented Mar 3, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Breaking-Change Type: dependencies Pull requests that update a dependency file(s) labels Mar 3, 2020
@josesimoes josesimoes force-pushed the update-winrt-api branch 4 times, most recently from 26e74a9 to 8bc4505 Compare March 3, 2020 03:08
@josesimoes
Replace WinRT components access
f478294 
- Moved to official Microsoft.Windows.SDK.Contracts.
- Upgrade projects to package.reference.
- Bump version to 1.10.0-preview.
- Replace nuget pack tasks in Azure yaml.

Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
@sonarcloud
Copy link

sonarcloud bot commented Mar 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@josesimoes josesimoes merged commit 0a40212 into nanoframework:develop Mar 3, 2020
@josesimoes josesimoes deleted the update-winrt-api branch March 3, 2020 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Breaking-Change Type: dependencies Pull requests that update a dependency file(s)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot