Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new method UpdateDebugFlags #191

Merged
merged 2 commits into from
Mar 14, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Add new method UpdateDebugFlags.

Motivation and Context

  • Part of the debug session launch workflow is setting the appropriate flags on the target debugger engine at some point. The current approach was to call ConnectAsync, operation on which those flags are set. It happens that the ConnectAsync performs A LOT of other operations (managing the VS debugger engine, calling the low level connect API, querying device capabilities, etc). All these are not only unnecessary at this step but have the potential to wreck the debugger engine and the low level connection and stress the device CLR with a lot of unnecessary chat on the receiver thread. Adding this simple method that perform exactly what's required at that step is much more efficient and logical.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@nfbot
Copy link
Member

nfbot commented Mar 14, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 1188e96 into nanoframework:develop Mar 14, 2019
@josesimoes josesimoes deleted the josesimoes-patch-2 branch March 14, 2019 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants