Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in network configuration #133

Merged

Conversation

josesimoes
Copy link
Member

Description

  • Add InterfaceType in NetworkInterface
  • Rename several configuration related classes to match last version
  • Add comments to network information enums to clarify where those come from
  • Rework namespaces to get rid of ambiguity with framework System.Net
  • Rework Wireless80211 class so it's not extending NetworkInterface config
  • Update test app

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [x All new and existing tests passed.

Signed-off-by: josesimoes jose.simoes@eclo.solutions

- Add InterfaceType in NetworkInterface
- Rename several configuration related classes to match last version
- Add comments to network information enums to clarify where those come from
- Rework namespaces to get rid of ambiguity with framework System.Net
- Rework Wireless80211 class so it's not extending NetworkInterface config
- Update test app

Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
@nfbot
Copy link
Member

nfbot commented Apr 17, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 53fb457 into nanoframework:develop Apr 17, 2018
@josesimoes josesimoes deleted the improve-network-configuration branch April 17, 2018 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants