Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework async and sync requests #112

Merged

Conversation

josesimoes
Copy link
Member

Description

  • Rework async and sync requests
  • TaskCompletionSource now uses fixed type instead of object
  • Extra check for cancelation request on serial send and receive methods

Motivation and Context

  • Work on improving general stability and solve VS hanging

How Has This Been Tested?

  • WPF test app and VS experimental instance

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@nfbot
Copy link
Member

nfbot commented Jan 18, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 18935ff into nanoframework:develop Jan 18, 2018
@josesimoes josesimoes deleted the improvements-sync-and-async-requests branch January 18, 2018 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants