Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work on sync requests #111

Merged
merged 1 commit into from
Jan 5, 2018
Merged

Work on sync requests #111

merged 1 commit into from
Jan 5, 2018

Conversation

josesimoes
Copy link
Member

Description

  • Improve code in PerformSyncRequest methods
  • Adjust packet size for WriteMemory
  • Remove some ConfigureAwait that wheren't doing much
  • Update test app to mimic a real deployment scenario

Motivation and Context

  • Fixes deployment issues for deployment blobs on which the remainder package was smaller than 64 bytes.

How Has This Been Tested?

  • WPF test app (updated specifically to test this issue)

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes
Work on sync requests
a2d8015 
- Improve code in PerformSyncRequest methods
- Adjust packet size for WriteMemory
- Remove some ConfigureAwait that wheren't doing much
- Update test app to mimic a real deployment scenario

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@nfbot
Copy link
Member

nfbot commented Jan 5, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 416aaa6 into nanoframework:develop Jan 5, 2018
@josesimoes josesimoes deleted the work-sync-requests branch January 5, 2018 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot