Update to wgpu 0.12, egui 0.18 #861
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes removing the unnecessary block attr from nannou draw wgsl vertex shader
WIP as demo app immediately `panic!`s with a wgpu error when running.
In the migration of `egui_wgpu_backend` into the main repositories, it looks like results are no longer returned, so there's no error handling to be done here.
|
May be superseded by #940 |
6 tasks
|
Maybe we should close this now that #940 has been merged.. |
|
Closed via #940 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally getting around to updating these!
The
wgpuupdate is quite trivial and looks like the new validation errors might make it easier to catch bugs in the WIPnannou_isfcrate.The
eguiupdate however needs a more significant refactor. It looks like theegui_winit_platformandegui_wgpu_backendcrates have recently been merged into the maineguirepo asegui-winitandegui-wgpurespectively. Awesome to see these being maintained upstream, but both have transformed quite a bit and require some rethinking ofnannou_eguiandnannou_egui_demo_app.TODO
nannou_wgputowgpu0.12.nannoutowgpu0.12.nannou_isftowgpu0.12.nannou_eguitoegui0.18. Mostly done, though need to refactor eframe stuff for demo app.nannou_egui_demo_app. Changed significantly, might need to copy over quite a bit of boilerplate fromegui_demo_app.wgpuexamples to0.12.