feat: shared libs #320
Merged
feat: shared libs #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StyleT
suggested changes
Sep 2, 2021
| <FormTab label="Summary"> | ||
| {mode === 'edit' | ||
| ? <TextField source="name" /> | ||
| : <TextInput source="name" fullWidth />} |
There was a problem hiding this comment.
I think we shouldn't allow change of name since it's a primary key and ID of the entity
There was a problem hiding this comment.
but here we use TextFIELD for "edit" and "TextINPUT" for "create",
or I missed something?
nightnei
force-pushed
the
featSharedLibs
branch
from
e684d46
to
1271727
Compare
StyleT
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.