Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on nightly #7

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Fix build on nightly #7

merged 1 commit into from
Jun 10, 2021

Conversation

rajivshah3
Copy link
Contributor

The build fails on the nightly toolchain because of the following error:

error[E0557]: feature has been removed
 --> ~/.cargo/registry/src/github.51.al-1ecc6299db9ec823/pharos-0.5.1/src/lib.rs:1:33
  |
1 | #![ cfg_attr( nightly, feature( external_doc, doc_cfg    ) ) ]
  |                                 ^^^^^^^^^^^^ feature has been removed
  |
  = note: use #[doc = include_str!("filename")] instead, which handles macro invocations

error: aborting due to previous error

For more information about this error, try `rustc --explain E0557`.
error: could not compile `pharos`

I think this PR should resolve the issue

@najamelan
Copy link
Owner

najamelan commented Jun 10, 2021

Hi, yes. I'm in the process of updating my libs. However, this will require an extra cfg_attr, otherwise it will still try to evaluate include_str! on stable... So it should be:

#![cfg_attr( nightly, cfg_attr( nightly, doc = include_str!("../README.md") ) )]

See: rust-lang/rust#82768

@rajivshah3
Copy link
Contributor Author

Ooh, ok 👍

@najamelan
Copy link
Owner

Do you want to push force the fix? Then I will merge it in and release a new version.

@najamelan najamelan merged commit e3041d1 into najamelan:dev Jun 10, 2021
@rajivshah3 rajivshah3 deleted the fix/nightly branch June 10, 2021 15:40
najamelan added a commit that referenced this pull request Jun 10, 2021
* dev:
  Update dependencies, changelog and version number.
  Silence warning about name ambiguity.
  Silence a clippy warning.
  Remove travis config.
  Fix build on nightly (#7)
@najamelan
Copy link
Owner

Version 0.5.2 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants