This repository has been archived by the owner on Oct 19, 2022. It is now read-only.
Awesome API Documentation #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
dignifiedquire
changed the title
victorb
reviewed
Dec 12, 2016
| @@ -9,13 +9,26 @@ const select = require('../select') | |||
|
|
|||
| const PROTOCOL_ID = require('./../constants').PROTOCOL_ID | |||
|
|
|||
| module.exports = class Dialer { | |||
| /** | |||
| * | |||
There was a problem hiding this comment.
This is missing a definition no?
There was a problem hiding this comment.
Well it could of course use some more description, but for showing up this is enough, as class etc is extracted from the code
victorb
approved these changes
Dec 12, 2016
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref ipfs/js-ipfs#615
Preview: https://multiformats.github.io/js-multistream-select/