This repository has been archived by the owner on Aug 24, 2021. It is now read-only.
Awesome API Documentation #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
dignifiedquire
changed the title
victorb
reviewed
Dec 12, 2016
| * by `func`. | ||
| * | ||
| * @param {Buffer} buf - The value to hash. | ||
| * @param {number|string} func - The algorithm to use. |
There was a problem hiding this comment.
Hm, this looks weird, func should be number or string. Reason would be because we change the argument orders if there are optional arguments. However, I can see this being confusing. Any ideas on how we can make it better?
There was a problem hiding this comment.
I'm not sure I understand, is your issue the name func, because the definition I wrote is number or string.
victorb
approved these changes
Dec 12, 2016
|
Users won't find API with only this https://github.com/multiformats/js-multihashing-async#api |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref ipfs/js-ipfs#615
Preview: https://multiformats.github.io/js-multihashing-async/