fix: export only identity hasher const
#163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basics.js uses `...identity` from the import, so `name` and friends get mixed up as hashers. Instead of removing `identity` and making basics import a single multihasher from `*`, we'll fix this for now (non-breaking) and maybe introduce a breaking change to switch the export later. Fixes: ipfs/js-ipfs#4020
|
I did notice the export differences in #160 when reviewing, but didn't anticipate this problem! Will do a quick release to deal with the ecosystem breakage that we've unleashed. |
This was referenced Jan 20, 2022
|
🎉 This PR is included in version 9.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basics.js uses
...identityfrom the import, so as of 9.6.0 (via #160)nameand friends get mixed up as hashers, which they are not.This could be fixed in basics.js, but I think its usage tells us that #160 was a breaking change. So we'll do a revert-ish of the exports, and deal with the interface later with a breaking change if we think that a
*export of identity (which wouldn't match the sha2 export) is the right way to go.Fixes: ipfs/js-ipfs#4020