Inclusion of Skein #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What are these codecov tests? |
|
They are testing for code coverage. Your new functions are not covered by tests. |
|
@Kubuxu All the tests in Travis has passed, yet the tests in codecov is not? |
|
@Kubuxu I give up on Go. If you can find someone who can patch it, and fix the Hash code for BLAKE2 and Skein, that would be great. 😭 |
|
List of repos with good Skein implementations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a new add-on for Multihash (see multiformats/multihash#83
and multiformats/multihash#82)
I have added some Go code to the files to comply with the new proposed standard.
I know only a minimal amount of Go, hope someone can correct me.