fix: update /x/exp package and fix sorting #207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update /x/exp to match the go 1.21 "slices" package. The signature of slices.SortFunc changed to now require the function return an integer instead of a boolean for sorting. Fix the call to slices.SortFunc. This fixes the build on Go 1.21 when downstream projects import a newer version of /x/exp than the current version of multiaddr. Signed-off-by: Christian Stewart <christian@aperture.us>
This was referenced Jul 27, 2023
|
@marten-seemann Fixed - split into two PRs. Confirmed that the other PR is necessary to fix a go1.21 test failure: #212 but it's unrelated to this PR. |
1 task
|
Fixed by #210. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update /x/exp to match the go 1.21 "slices" package.
The signature of slices.SortFunc changed to now require the function return an integer instead of a boolean for sorting. Fix the call to slices.SortFunc.
This fixes the build on Go 1.21 when downstream projects import a newer version of /x/exp than the current version of multiaddr.