Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

absorb go-maddr-filter; rm stale Makefile targets; upgrade deps #124

Merged
merged 1 commit into from
May 14, 2020
Merged

absorb go-maddr-filter; rm stale Makefile targets; upgrade deps #124

merged 1 commit into from
May 14, 2020

Conversation

raulk
Copy link
Member

@raulk raulk commented May 14, 2020 •
edited
Loading

The deprecation PR at go-maddr-filter is at: libp2p/go-maddr-filter#23. Once this is merged, I will make a release, update the gomod on the other end, merge that PR, and make a release there.

Also:

  • remove stale targets from Makefile.
  • upgrades a dependency.

Context: libp2p/go-libp2p#829

@raulk raulk mentioned this pull request May 14, 2020
Merged
1 task
@raulk raulk requested review from Stebalien and Kubuxu May 14, 2020 11:51
Stebalien
Stebalien approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're planning on completely deprecating this package in favor of the connection gating logic, this may not be worth it.

I'd also consider making this a sub-package, but have no strong preference.

Otherwise, LGTM.

@raulk raulk changed the title absorb go-maddr-filter into go-multiaddr. absorb go-maddr-filter into go-multiaddr; remove stale Makefile targets; upgrade deps May 14, 2020
@raulk raulk changed the title absorb go-maddr-filter into go-multiaddr; remove stale Makefile targets; upgrade deps absorb go-maddr-filter; rm stale Makefile targets; upgrade deps May 14, 2020
@raulk raulk merged commit 192ac0f into master May 14, 2020
@raulk raulk deleted the migrate/filters branch May 14, 2020 15:34
@Stebalien
Copy link
Member

Hm. I regret not having a strong preference. Having random multiaddr filter types in the root package is annoying.

@Stebalien Stebalien mentioned this pull request May 26, 2020
Closed
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raulk @Stebalien