Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Alpine 3.18 by Debian 12 as the base image #201

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Conversation

multani
Copy link
Owner

@multani multani commented Nov 6, 2023

This replaces the base image from Alpine 3.18 to Debian 12.

The main driver for this change (not implemented yet here) is to easily support arm64 images in the future.

Nomad relies on the gblic for several functionalities and there are no good up to date glibc packages for Alpine.
Changing the underlying libc of the Alpine image is also a bit risky and defeats a bit the purpopse of using this base image in the first place.

This should also help to embark other Nomad plugins, and/or Docker-related plugins by having a more general base image. After all, Nomad itself is most probably expecting to run not on Alpine-based VMs in real scenarios.

This increases the size of the final Docker image a bit: in my test, the image increases from 150 MB to 190 MB, but it's still relatively small and Debian opens more possibilities in the future.

See: #133 and initial experiment in #55.

@multani multani added the docker Pull requests that update Docker code label Nov 6, 2023
@multani multani self-assigned this Nov 6, 2023
@multani multani mentioned this pull request Nov 6, 2023
This replaces the base image from Alpine 3.18 to Debian 12.

The main driver for this change (not implemented yet here) is to easily
support arm64 images in the future.

Nomad relies on the gblic for several functionalities and there are no
good up to date glibc packages for Alpine.
Changing the underlying libc of the Alpine image is also a bit risky and
defeats a bit the purpopse of using this base image in the first place.

This should also help to embark other Nomad plugins, and/or
Docker-related plugins by having a more general base image. After all,
Nomad itself is most probably expecting to run not on Alpine-based *VMs*
in real scenarios.

This increases the size of the final Docker image a bit: in my test, the
image increases from 150 MB to 190 MB, but it's still relatively small
and Debian opens more possibilities in the future.
@multani multani merged commit f7d95a0 into master Nov 6, 2023
6 checks passed
@multani multani deleted the debian-image branch November 6, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant