[material-ui][Autocomplete] Add custom props support via slotProps
#43613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-43613--material-ui.netlify.app/ Bundle size report |
ZeeshanTamboli
changed the title
ZeeshanTamboli
added
package: material-ui
There was a problem hiding this comment.
Hey @Michael-Hutchinson, thanks for the PR! Could you also add a TypeScript module augmentation test? You can refer to this test: https://github.com/mui/material-ui/blob/master/packages/mui-material/test/typescript/moduleAugmentation/alertCustomSlotProps.spec.tsx. Let me know if you need any help.
Michael-Hutchinson
force-pushed
the
bugfix/autocomplete-scrolling-to-top
branch
from
e4c6abd
to
556caeb
Compare
ZeeshanTamboli
changed the title
slotProps
ZeeshanTamboli
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
@Michael-Hutchinson I wrote a proper test case testing both paper and popper slots. Thanks for the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #43609