Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][figma] Clarity state or Figma Plugin component export #43543

Merged
merged 6 commits into from
Sep 2, 2024

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 31, 2024

I saw a couple of comments about this in https://www.figma.com/community/plugin/1336346114713490235/material-ui-sync, e.g. mui/mui-design-kits#389 asking about

why the theme only generates 3 components?

A general thought, anytime we no a major, we should try to remove stuff aggressively: https://youtu.be/tRsxLLghL1k?si=sRhbVRHVLRR83pMX&t=574. This feature might be je trending toward being removed.

Before: https://mui.com/material-ui/design-resources/material-ui-sync/#customizing-components
After: https://deploy-preview-43543--material-ui.netlify.app/material-ui/design-resources/material-ui-sync/#customizing-components

I saw a couple of comments about this in https://www.figma.com/community/plugin/1336346114713490235/material-ui-sync. Right now, this feature is trending toward being removed, so we shouldn't promise more coverage.

A general thought, anytime we no a major, we should try to remove stuff aggressively: 

Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation design: material This is about Material Design, please involve a visual or UX designer in the process labels Aug 31, 2024
@mui-bot
Copy link

mui-bot commented Aug 31, 2024

…ui-sync.md

Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
…ui-sync.md

Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
…ui-sync.md

Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Copy link
Contributor

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense! I just have a couple of remarks, but nothing that should block the PR :)

…ui-sync.md

Co-authored-by: Victor Zanivan Monteiro <victorzanivan@gmail.com>
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@oliviertassinari oliviertassinari enabled auto-merge (squash) September 2, 2024 20:37
@oliviertassinari oliviertassinari merged commit 9063a9d into master Sep 2, 2024
27 checks passed
@oliviertassinari oliviertassinari deleted the oliviertassinari-patch-1 branch September 2, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design: material This is about Material Design, please involve a visual or UX designer in the process docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants