Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update the Material UI readme post-v6 #43504

Merged
merged 9 commits into from
Sep 6, 2024

Conversation

samuelsycamore
Copy link
Member

@samuelsycamore samuelsycamore commented Aug 28, 2024

  • make Material UI the primary focus of the repo
  • add v5 -> v6 upgrade link
  • "migration" -> "upgrading"
  • add disclaimer that Joy UI is on hold and Material UI is recommended for new projects

Before: https://github.com/mui/material-ui/blob/eea5079a00bedb68e27f22b7f94d9a71cc97ee1e/README.md
After: https://github.com/samuelsycamore/material-ui/blob/readme-update-late-24/README.md

@samuelsycamore samuelsycamore added the docs Improvements or additions to the documentation label Aug 28, 2024
Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Aug 29, 2024
@mui-bot
Copy link

mui-bot commented Aug 29, 2024

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against deefa74

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@samuelsycamore
Copy link
Member Author

Reviewing the earlier draft that I submitted, I felt that the Joy UI section was taking up too much space relative to the Material UI section, which should be the main focus. So I reviewed some benchmarks of other popular open source lib readmes and wrote a little more copy about Material UI. Also added a link to MUI X for good measure, because we should be more proactive about directing Material UI users to X. Eventually I think we should link to Toolpad, Pigment CSS, and Base UI as well, but maybe not yet.

@samuelsycamore
Copy link
Member Author

Also updated the Joy UI Getting Started doc to align with the new readme copy:

Screenshot 2024-09-02 at 8 59 22 AM

README.md Outdated

### Material UI
Material UI's core functionality is extended by [MUI X](https://github.com/mui/mui-x), a suite of complex components for advanced use cases.
Copy link
Member

@oliviertassinari oliviertassinari Sep 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it wouldn't make sense to extend this a bit more. I could see use explaining Material UI as a library but also a stack, like shadcn.

In v6, this stack is only MUI System + the components.

In v7, this stack could look like this (can be different, only to illustrate our product trends for the last couple of months):

  • Base UI (@base-ui/react)
  • Material UI System (@material-ui/system), which is a slim wrapper on Pigment CSS, where Pigment CSS supports a runtime with emotion too.
  • Pre-designed components following Material Design built on top of those (@material-ui/md3), this package can be in anyone's codebase.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like this? (Should we mention Pigment CSS and/or Base UI as part of the "stack" currently?)

Material UI's core functionality is extended by MUI X, a suite of complex components for advanced use cases.

MUI System is a set of CSS utilities to help you build custom designs more efficiently. For modern CSS-in-JS with static CSS extraction and React Server Component / Next.js App Router support, try Pigment CSS (currently in beta).

Copy link
Member Author

@samuelsycamore samuelsycamore Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revisit this topic at another time, once this idea is a little more fleshed out. We can continue to iteratively update the readme content beyond the scope of this PR.

@samuelsycamore samuelsycamore merged commit a25b030 into mui:master Sep 6, 2024
22 checks passed
@samuelsycamore samuelsycamore deleted the readme-update-late-24 branch September 6, 2024 23:34
Michael-Hutchinson pushed a commit to Michael-Hutchinson/material-ui that referenced this pull request Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants