Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Pagination] Update getItemAriaLabel page param type #43399

Merged

Conversation

sydneyjodon-wk
Copy link
Contributor

This PR is to resolve #43385

@mui-bot
Copy link

mui-bot commented Aug 21, 2024

Netlify deploy preview

https://deploy-preview-43399--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 01ed6ab

@sai6855 sai6855 added typescript package: material-ui Specific to @mui/material component: pagination This is the name of the generic UI component, not the React module! labels Aug 22, 2024
@sydneyjodon-wk sydneyjodon-wk marked this pull request as ready for review August 22, 2024 16:06
@ZeeshanTamboli ZeeshanTamboli changed the title [mui-material][Pagination] Update getItemAriaLabel page param type [material-ui][Pagination] Update getItemAriaLabel page param type Aug 23, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui][Pagination] Update getItemAriaLabel page param type [material-ui][Pagination] Update getItemAriaLabel page param type Aug 23, 2024
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pagination This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[material-ui][Pagination] getItemAriaLabel called with null page number contrary to type definition
5 participants