Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][material-ui][Menu] Replace PaperProps with slotProps.paper in demos #43354

Merged
merged 4 commits into from
Aug 21, 2024
Merged

[docs][material-ui][Menu] Replace PaperProps with slotProps.paper in demos #43354

merged 4 commits into from
Aug 21, 2024

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Aug 18, 2024 •
edited
Loading

PaperProps have been deprecated from Menu but still being used in docs, this PR removes those instances

@sai6855 sai6855 marked this pull request as draft August 18, 2024 05:49
@mui-bot
Copy link

mui-bot commented Aug 18, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-43354--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 52410ef

@sai6855 sai6855 changed the title [material-ui][Menu] Remove PaperProps from docs [material-ui][Menu] Remove PaperProps from demos Aug 18, 2024
@sai6855 sai6855 marked this pull request as ready for review August 18, 2024 06:15
@sai6855 sai6855 changed the title [material-ui][Menu] Remove PaperProps from demos [material-ui][Menu] Replace PaperProps with slotProps.paper from demos Aug 18, 2024
@sai6855 sai6855 added docs Improvements or additions to the documentation component: menu This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Aug 18, 2024
@zannager zannager requested a review from mnajdova August 19, 2024 14:32
ZeeshanTamboli
ZeeshanTamboli reviewed Aug 21, 2024
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sai6855 Looks good. When its documentation related changes make sure to add [docs] tag in the PR title.

@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui][Menu] Replace PaperProps with slotProps.paper from demos [docs][material-ui][Menu] Replace PaperProps with slotProps.paper from demos Aug 21, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [docs][material-ui][Menu] Replace PaperProps with slotProps.paper from demos [docs][material-ui][Menu] Replace PaperProps with slotProps.paper in demos Aug 21, 2024
@ZeeshanTamboli ZeeshanTamboli merged commit c6cdde8 into mui:next Aug 21, 2024
25 checks passed
@Msolmaz4 Msolmaz4 mentioned this pull request Sep 17, 2024
Open
@shagg0r shagg0r mentioned this pull request Sep 18, 2024
Open
@prathik2401 prathik2401 mentioned this pull request Sep 18, 2024
Merged
@Msolmaz4 Msolmaz4 mentioned this pull request Sep 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
component: menu This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sai6855 @mui-bot @ZeeshanTamboli