Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Fix some TS issues for X docs #43285

Merged
merged 3 commits into from
Aug 14, 2024
Merged

[docs-infra] Fix some TS issues for X docs #43285

merged 3 commits into from
Aug 14, 2024

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Aug 13, 2024

Make some typing fixes that we need in X and Toolpad

  • Add typings for docs/src/modules/components/AppLayoutDocs.js. We can also migrate to TS, but this was quick and easy
  • Some type issues in docs/src/modules/components/ApiPage.tsx that for some reason are not reported in the core repo. To investigate

See mui/mui-x#14141

@Janpot Janpot changed the title Fix some TS issues in X [docs] Fix some TS issues for X Aug 13, 2024
@Janpot Janpot changed the title [docs] Fix some TS issues for X [docs-infra] Fix some TS issues for X Aug 13, 2024
@Janpot Janpot added the scope: docs-infra Specific to the docs-infra product label Aug 13, 2024
@mui-bot
Copy link

mui-bot commented Aug 13, 2024

Netlify deploy preview

https://deploy-preview-43285--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 5602fb4

@Janpot Janpot changed the title [docs-infra] Fix some TS issues for X [docs-infra] Fix some TS issues for X docs Aug 13, 2024
@Janpot Janpot requested a review from a team August 13, 2024 19:52
@Janpot Janpot marked this pull request as ready for review August 13, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants