-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[code-infra] Update package layout for better ESM support #43264
Draft
Janpot
wants to merge
49
commits into
mui:master
Choose a base branch
from
Janpot:esm-exports
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 40 commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
0c2d530
WIP
Janpot f0cc38e
exclude icons
Janpot 3955055
MUI_PACKAGE_EXPORTS
Janpot 33c43c1
more
Janpot 5888018
Update copyFilesUtils.mjs
Janpot 642fdcd
remove deep export
Janpot 868a81d
bring back flag
Janpot e03039f
Update ci.yml
Janpot f5bb040
WIP
Janpot da26652
Merge branch 'next' into esm-exports
Janpot 4229626
Update build.mjs
Janpot c11b8e5
remove this
Janpot a98520b
fix snapshot
Janpot 60e04ca
vite icons alias
Janpot 6e2bbcc
remove 'use client' from index.* fles
Janpot 9348956
Update package.json
Janpot 860a36e
Update package.json
Janpot 904f65b
Update package.json
Janpot 0de01ee
Revert "remove 'use client' from index.* fles"
Janpot 5172a89
bring changes to snashots
Janpot 9eaa517
Update webpack.config.js
Janpot 2011763
Merge remote-tracking branch 'upstream/master' into esm-exports
Janpot 4c44355
Update scripts/build.mjs
Janpot 626135d
Reapply "remove 'use client' from index.* fles"
Janpot b4e9968
remove 'use client'
Janpot 6bf0206
Update pnpm-lock.yaml
Janpot ba50924
Merge remote-tracking branch 'upstream/master' into esm-exports
Janpot 97f711a
fix tsc
Janpot f7b83b9
Update tsconfig.json
Janpot 32afa8d
Merge branch 'master' into esm-exports
Janpot 72beb0e
zis
Janpot bb746d1
update exports of icons
Janpot db13926
fix overrides of export field
Janpot ee3f56b
Merge branch 'master' into esm-exports
Janpot 85e1af7
Update build.mjs
Janpot d881880
next document fix
Janpot 66e9d33
ci
Janpot d4953d4
ci
Janpot c6212c5
Update pagesRouterV13Document.tsx
Janpot debe230
Update package.json
Janpot 02749c1
Update package.json
Janpot c1061e7
Update package.json
Janpot ff6c473
remove mjs
Janpot 096d907
remove unnecessary
Janpot 6074ce9
extension
Janpot 9aabf3b
Update copyFiles.mjs
Janpot 3cccf14
Merge remote-tracking branch 'upstream/master' into esm-exports
Janpot eedc2b9
Revert
Janpot 029389f
jdsh
Janpot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
packages/mui-material-nextjs/src/v13-pagesRouter/nextDocument.cjs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
module.exports = require('next/document'); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -104,6 +104,14 @@ | |
"engines": { | ||
"node": ">=14.0.0" | ||
}, | ||
"exports": { | ||
"/ButtonBase/TouchRipple": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maintain backwards compatibilty for https://github.com/mui/mui-x/blob/1a9426021bd72b5a1cc18e2c78a5a063d27be541/docs/data/data-grid/column-definition/RenderCellGrid.tsx#L4 |
||
"types": "./ButtonBase/TouchRipple.d.ts", | ||
"import": "./ButtonBase/TouchRipple.mjs", | ||
"mui-modern": "./ButtonBase/TouchRipple.moder.mjs", | ||
"require": "./ButtonBase/TouchRipple.js" | ||
} | ||
}, | ||
"pigment-css": { | ||
"vite": { | ||
"include": [ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1 @@ | ||
'use client'; | ||
export { default } from './useLazyRipple'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maintain backwards compatibility for users that have done
material-ui/apps/pigment-css-vite-app/vite.config.ts
Lines 48 to 55 in 8b8732e