Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Fine-tune button styles on the branding theme #43082

Merged
merged 6 commits into from
Jul 26, 2024

Conversation

zanivan
Copy link
Contributor

@zanivan zanivan commented Jul 26, 2024

This PR is to add some components to experiments gallery and branding theme, and to tweak buttons styles.

Changes include:

  • Fine-tune border radius of button variants to be consistent, and closer to shape.borderRadius in all sizes.
  • Further tweak the button styles, to be more consistent among themselves.
  • Add active states to buttons.
  • Add <Card variant="elevation"/> to brandingTheme

Preview:

👉 https://deploy-preview-43082--material-ui.netlify.app/experiments/website/branding-theme-test/

@zanivan zanivan added design This is about UI or UX design, please involve a designer website Pages that are not documentation-related, marketing-focused. labels Jul 26, 2024
@zanivan zanivan self-assigned this Jul 26, 2024
@mui-bot
Copy link

mui-bot commented Jul 26, 2024

Netlify deploy preview

https://deploy-preview-43082--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 03ca793

Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.


Probably unrelated to this PR, but this label is off:

Screenshot 2024-07-26 at 17 21 30

@zanivan
Copy link
Contributor Author

zanivan commented Jul 26, 2024

Probably unrelated to this PR, but this label is off:

Yep, I'm aware, and it's really bad tbh—I'll open another PR specifically for tweaking textfields. I didn't change anything related to this one yet, just added to the components' gallery. We're using many different TexFields among the website, and most of the styles are locally, so I thought it would be good to have a PR specific for them 😅

@zanivan zanivan merged commit 7b632ea into next Jul 26, 2024
28 checks passed
@zanivan zanivan deleted the components-brandingtheme branch July 26, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants