[docs] Link Toolpad Core components from Material Ui docs #43036
Conversation
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
|
@prakhargupta1 Fixed it but in latest weekly we decided to not add demos to these experimental sections. They could confuse users on the page. Users may not always be reading the text and just see a demo => copy + paste. |
github-actions
bot
removed
the
PR: out-of-date
|
I reworked copy a bit and removed the demos. I left one demo in as sort of a showcase. It doesn't have a preview to not give users the false impression it's part of Material UI. Just as happy to leave it out as well. wdyt? |
This form looks great to me; I would prefer having them on all components that we're touching, not just the Dialog and AppBar |
We have it on appbar, drawer, container, breadcrumbs. Essentially the pages for components people would be on when build application layout. I'm not sure it would make sense to put on other component pages. I don't think we can really properly showcase the imperative APIs without also showing code and I'd like to avoid that. Therefore I propose we leave Dialog/Snackbar as is. |
|
Couldn't find a reference of adding beta chip in .md files, so simple added (beta) to the title, like it was done here. 
|
|
|
||
| ### Imperative API | ||
|
|
||
| You can create and manipulate notifications imperatively with the [`useNotifications`](https://mui.com/toolpad/core/react-use-notifications/) API in `@toolpad/core`. This API provides state management for opening and closing snackbars. It also allows for queueing multiple notifications at once. |
There was a problem hiding this comment.
This felt a bit hard to grasp. I could see a live demo like we have above for notistack.
There was a problem hiding this comment.
We intentionally avoided adding code snippets that weren't "@mui/material native" to not confuse users. And a demo without a snippet isn't as useful as the feature is in the API shape. Not sure this fully makes sense though.
There was a problem hiding this comment.
I was thinking of having the equivalent to https://mui.com/material-ui/react-snackbar/#notistack.
There was a problem hiding this comment.
Planning a refinement for the next iteration mui/toolpad#4007
| @@ -134,3 +134,11 @@ Apps focused on information consumption that use a left-to-right hierarchy. | |||
| Apps focused on productivity that require balance across the screen. | |||
|
|
|||
| {{"demo": "ClippedDrawer.js", "iframe": true}} | |||
|
|
|||
| ## Experimental APIs | |||
There was a problem hiding this comment.
Framing this as an experiment API feels wrong. I can understand why for the others components, these are things that should arguably be built-in features of the core components. But this one feels too high-level and opinionated to fit into Material UI product/brand.
Preview of Toolpad Core on templates page: https://deploy-preview-43036--material-ui.netlify.app/material-ui/getting-started/templates/
To do for templates section