Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][docs] Simplify components styling on templates #41845

Merged
merged 9 commits into from
Apr 16, 2024

Conversation

zanivan
Copy link
Contributor

@zanivan zanivan commented Apr 10, 2024

This PR is for turning the heavy styled components into StyledComponents instead of using sx prop on the free Material UI templates.

@zanivan zanivan added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material design This is about UI or UX design, please involve a designer labels Apr 10, 2024
@zanivan zanivan self-assigned this Apr 10, 2024
@mui-bot
Copy link

mui-bot commented Apr 10, 2024

Netlify deploy preview

https://deploy-preview-41845--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against a259a05

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last few remarks — the rest look solid!

@zanivan zanivan merged commit 36e95e2 into mui:next Apr 16, 2024
19 checks passed

const SignInContainer = styled(Stack)(({ theme }) => ({
height: 'auto',
padingBottom: theme.spacing(12),
Copy link
Member

@oliviertassinari oliviertassinari Jun 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
padingBottom: theme.spacing(12),
paddingBottom: theme.spacing(12),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants