Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Use Circle CI context #41532

Merged
merged 1 commit into from
Mar 17, 2024

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Mar 17, 2024

This PR means that we don't have to duplicate the same tokens in each GitHub repository configuration. Simpler for the code-infra to work on the codebase by defining them once (e.g. token rotation). So far, we have 3 variables shared between the repositories.

SCR-20240317-ptgn

https://app.circleci.com/settings/organization/github/mui/contexts/3f0e38e1-5317-4a70-9505-f9b8ccc9fee2?return-to=https%3A%2F%2Fapp.circleci.com%2Fpipelines%2Fgithub%2Fmui


Note that all open PRs need to be rebased on HEAD to work. I removed the tokens of each Circle CI repository that duplicate with the Circle CI organization.


This is part of the larger effort to break down Material UI into projects of smaller scopes, so they have a stronger chance to be entry points for developers, but also so we have more focus.

@oliviertassinari oliviertassinari added core Infrastructure work going on behind the scenes scope: code-infra Specific to the core-infra product labels Mar 17, 2024
@oliviertassinari oliviertassinari force-pushed the circle-ci-use-context branch 2 times, most recently from b8e9ad0 to 9d9b038 Compare March 17, 2024 16:18
@mui-bot
Copy link

mui-bot commented Mar 17, 2024

Netlify deploy preview

https://deploy-preview-41532--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 6c2e463

@oliviertassinari
Copy link
Member Author

It works:

SCR-20240317-phek

oliviertassinari added a commit to mui/base-ui that referenced this pull request Mar 17, 2024
oliviertassinari added a commit to mui/mui-x that referenced this pull request Mar 17, 2024
oliviertassinari added a commit to mui/toolpad that referenced this pull request Mar 17, 2024
oliviertassinari added a commit to mui/mui-public that referenced this pull request Mar 17, 2024
@oliviertassinari oliviertassinari merged commit 32c22e9 into mui:master Mar 17, 2024
19 checks passed
@oliviertassinari oliviertassinari deleted the circle-ci-use-context branch March 17, 2024 16:55
@oliviertassinari oliviertassinari changed the title [core] Use Circle CI context [code-infra] Use Circle CI context Mar 17, 2024
cherniavskii pushed a commit to cherniavskii/mui-x that referenced this pull request Mar 29, 2024
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
adonislucky pushed a commit to adonislucky/base-ui that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants