[core][base-ui] Remove @mui/base dev dependency from Base UI workspace
#41216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeeshanTamboli
added
package: base-ui
Netlify deploy previewhttps://deploy-preview-41216--material-ui.netlify.app/ Bundle size report |
ZeeshanTamboli
changed the title
@mui/base dev dependency from Base UI workspace@mui/base dev dependency from Base UI workspace
|
With aliases in place, this indeed does work. As for the pnpm docs, this was added by Olivier (pnpm/pnpm.io#499). I suppose the correct term would be "MUI Core", but we want to limit the usage of it. Material UI is the main project in this repo (with Base UI being moved to a separate repo soon), so I suppose it's OK. |
michaldudak
approved these changes
Feb 21, 2024
ZeeshanTamboli
deleted the
remove-base-ui-package-from-the-base-ui-workspace
branch
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also saw this comment: #36287 (comment) but the tests do pass. Other workspaces also don't refer itself. Or am I missing something?
Also, while going through the workspace documentation, I came across this example:
Should it be named MUI?