Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Slider] Modernize implementation #583

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[Slider] Modernize implementation #583

wants to merge 3 commits into from

Conversation

mj12albert
Copy link
Member

@mj12albert mj12albert commented Sep 5, 2024 •
edited
Loading

  1. Replaced useCompound with Composite

Previously the id attribute of all the input elements were passed to useCompound as metadata to generate the for attribute of the output element.

However the refs provided by Composite can't be used during the render of Output for this, so the ids have to be held in a new state

  1. converted types to namespaces
  2. (Partially?) tackle [slider] Add missing webkit-appearance: slider-vertical CSS #635

@mj12albert mj12albert added the component: slider This is the name of the generic UI component, not the React module! label Sep 5, 2024
@mui-bot
Copy link

mui-bot commented Sep 5, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-583--base-ui.netlify.app/

Generated by 🚫 dangerJS against f3e90f3

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 5, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 5, 2024
@mj12albert mj12albert force-pushed the refactor/slider-composite branch 4 times, most recently from 753b46c to 04e16b3 Compare September 10, 2024 16:34
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 11, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 11, 2024
@mj12albert mj12albert marked this pull request as ready for review September 13, 2024 09:51
@mj12albert mj12albert marked this pull request as draft September 20, 2024 04:30
@mj12albert mj12albert changed the title [Slider] Replace useCompound with Composite [Slider] Modernize implementation Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomiks atomiks Awaiting requested review from atomiks atomiks is a code owner

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

@michaldudak michaldudak Awaiting requested review from michaldudak michaldudak is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component: slider This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mj12albert @mui-bot