Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add LDAP custom mapper resource #863

Merged

Conversation

NataliaKhodiakova
Copy link
Contributor

@NataliaKhodiakova NataliaKhodiakova commented Jul 18, 2023

Added resource to configure self-deployed custom LDAP mapper (#862)

fixes: #862

@punycode
Copy link

Today, while working on terraforming a Keycloak installation for a customer, I came across the exactly same need and already wanted to fire up my Go IDE. Then I found this PR and can totally agree with the need for such a terraform resource.

I only have one additional thing to add: such a resource should support a map backed config attribute in the same way as keycloak_generic_protocol_mapper (code) does. This would be needed for some custom LDAP mappers, that need additional configuration.

@NataliaKhodiakova
Copy link
Contributor Author

Hi @punycode thanks for the feedback! I added the optional config attribute to the resource

@mrparkers
Copy link
Owner

Hi @NataliaKhodiakova @punycode, sorry for the delay on this. I was able to pull this down and experiment with this locally. Thanks for adding the example and tests. Everything here looks great

@mrparkers mrparkers merged commit 07915d1 into mrparkers:master Jan 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for custom LDAP mappers
3 participants