Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for LDAP user attribute default value and binary attributes #735

Merged
merged 5 commits into from
Oct 6, 2022
Merged

add support for LDAP user attribute default value and binary attributes #735

merged 5 commits into from
Oct 6, 2022

Conversation

joeyberkovitz
Copy link
Contributor

Closes #734

Adds two optional attributes to the LDAP user attribute mapper: attribute_default_value and is_binary_attribute

@joeyberkovitz
Copy link
Contributor Author

rebased to current master

mrparkers
mrparkers approved these changes Oct 6, 2022
View reviewed changes
Copy link
Owner

@mrparkers mrparkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR. I made a couple of minor changes, but otherwise everything LGTM 🚀

@mrparkers mrparkers merged commit 57703c3 into mrparkers:master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrparkers mrparkers mrparkers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LDAP user mapper default value
2 participants
@joeyberkovitz @mrparkers