-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resource_type on keycloak_openid_client_authorization_permission #702
Add resource_type on keycloak_openid_client_authorization_permission #702
Conversation
…_permission See issue mrparkers#398 for details. Also adds docs for keycloak_openid_client_authorization_permission as well.
339e909
to
bc9aeac
Compare
@mrparkers any chance you could review this? This is blocking me from implementing some features and the changes are pretty minimal. |
@mrparkers any word on this? I don't want this MR to languish and fall by the wayside. I see other MRs getting merged so some feedback on what I need to change or do to get this merged would be great. |
I'm sorry @JessieAMorris, you're right that I've been neglecting this one. At a glance the code LGTM, and I also really appreciate adding the docs for this resource too. Give me an hour or two to pull this down locally and get a feel for it, and I'll get this merged and cut a release for you today. Thanks for your patience! |
@@ -59,6 +60,10 @@ func resourceKeycloakOpenidClientAuthorizationPermission() *schema.Resource { | |||
Elem: &schema.Schema{Type: schema.TypeString}, | |||
Optional: true, | |||
}, | |||
"resource_type": { | |||
Type: schema.TypeString, | |||
Optional: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the GUI, it looks like you can't set the resource type and a list of resources. Should we add a ConflictsWith
here and within the resources
attribute?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and pushed this change to your branch so I could get this merged / released today. If it turns out you don't think this is needed, we can remove it in a follow-up PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks. I had that change being made but was running acceptance tests! Sorry about the delay getting back to you, it's been a crazy morning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have nothing to apologize for, I'm pretty sure my delay in reviewing this PR was longer 😉
I just wanted to get this merged and released today like I promised, and I'm about to board a flight in a few hours and wouldn't be able to get to it then.
Thanks again for the PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the PR, so sorry for the super long delay on this one.
Thanks for the merge! Looking forward to using this in my code. :-) |
See issue #398 for details. Also
adds docs for keycloak_openid_client_authorization_permission as well.