-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add [keycloak_user_groups] resource #505
Merged
mrparkers
merged 13 commits into
mrparkers:master
from
StatueFungus:add-user-groups-resource
Apr 9, 2021
Merged
Add [keycloak_user_groups] resource #505
mrparkers
merged 13 commits into
mrparkers:master
from
StatueFungus:add-user-groups-resource
Apr 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Benedikt <benedikt.suessmann@sva.de>
…he user_groups resource is non-exhaustive
* implement resource_keycloak_user_groups * implement exhaustive mode of keycloak_user_groups * also remove groups when they are removed from the resource. Even if the user_groups resource is non-exhaustive Co-authored-by: Benedikt <benedikt.suessmann@sva.de>
…he user_groups resource is non-exhaustive
…rraform-provider-keycloak into add-user-groups-resource
mrparkers
approved these changes
Apr 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for the PR! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, this PR adds a
keycloak_user_groups
resource. It is inspired by theaws_iam_user_group_membership
resource and implements a non-exhaustive mode like #501