Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for multivalue attributes for users, groups and roles #499

Merged
merged 1 commit into from
Mar 25, 2021
Merged

support for multivalue attributes for users, groups and roles #499

merged 1 commit into from
Mar 25, 2021

Conversation

StatueFungus
Copy link
Contributor

Fixes #451

mrparkers
mrparkers approved these changes Mar 25, 2021
View reviewed changes
Copy link
Owner

@mrparkers mrparkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. we might want to revisit splitting on 255 characters still, or throwing a validation error if an attribute is longer than 255 characters, but this should work for now.

thanks for the PR!

@mrparkers mrparkers merged commit bfe1bd2 into mrparkers:master Mar 25, 2021
@StatueFungus StatueFungus deleted the support-multivalue-attributes branch March 29, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrparkers mrparkers mrparkers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multivalued user attributes mapping
2 participants
@StatueFungus @mrparkers