Add attributes management to keycloak_role #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This alters the last bit of the above to return a fresh ersult from resourceKeycloakRoleRead instead of interpretting things for itself.
mrparkers
approved these changes
Feb 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the attributes field to keycloak roles.
A couple of small tweaks popped in due to my linter and I slightly reworked the after the PUT update in the role update function to return a call to read instead of processing and updating directly.
This is a pretty simple addition, most of it was cribbed from how realm attributes were handled with minor changes to reflect realm.attributes and role.attributes not being the same type in the JSON.