Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for configuration of client scopes on realm level #464

Conversation

thomasdarimont
Copy link
Collaborator

Fixes #463

@thomasdarimont thomasdarimont force-pushed the issue/463-Add-support-for-realm-client-scope-config branch 4 times, most recently from 76273cd to 5a54b02 Compare January 13, 2021 16:34
@thomasdarimont thomasdarimont force-pushed the issue/463-Add-support-for-realm-client-scope-config branch from 5a54b02 to 42e7953 Compare January 13, 2021 16:52
Copy link
Owner

@mrparkers mrparkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the PR!

@mrparkers mrparkers merged commit 5f597ac into mrparkers:master Jan 23, 2021
@thomasdarimont
Copy link
Collaborator Author

@mrparkers it turns out that this feature is incomplete... /o\
We also need to make the clientScopes to have full control over the mapping.

I'll send another PR ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for configuration of client scopes on realm level
2 participants