Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field session_note to user session protocol mapper. This field ne… #365

Merged
merged 6 commits into from
Sep 20, 2020

Conversation

hcl31415
Copy link
Contributor

Add field session_note to user session protocol mapper. This field needs to be written additionally to session_note_label if the protocol mapper is intended to work correctly, e.g. an Apache mod_auth_openidc client.

@mrparkers
Copy link
Owner

Huh, I swear this attribute in the protocol mapper used to be called "session note label", but it appears to have disappeared completely from the UI. I think it might have been silently renamed in one of the releases since I originally created this resource.

What do you think about simply renaming the existing session_note_label attribute to session_note? If you're fine with this, I can push the change to your branch, or you could take a stab at it.

@hcl31415
Copy link
Contributor Author

hcl31415 commented Sep 4, 2020

That's perfectly fine with me. I just kept the original session note label field because I didn't want to introduce unintended behaviour in Keycloak. It seems though that the value of the session note label is still stored in the database, when PUT or POST against the admin API but in the end I couldn't find out what it really does.

Clemens Hanel added 2 commits September 11, 2020 18:09
…eds to be written additionally to session_note_label if the protocoll mapper is intended to work correctly, e.g. an Apache mod_auth_openidc client
@hcl31415
Copy link
Contributor Author

I removed the session-note-label field from the commit.

Copy link
Owner

@mrparkers mrparkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mrparkers mrparkers merged commit f16f846 into mrparkers:master Sep 20, 2020
hcl31415 added a commit to hcl31415/terraform-provider-keycloak that referenced this pull request Oct 12, 2020
…ol_mapper, deprecate session_note_label attribute (mrparkers#365)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants