resource to enable the token exchange idp permission #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 12, 2020 11:54
|
Strange all the tests passed. I did not expect this.... //edit Probably the token exchange itself will not work till you have the feature enabled. |
mrparkers
reviewed
Jun 12, 2020
docs/resources/keycloak_identity_provider_token_exchange_scope_permission.md
Outdated
Show resolved
Hide resolved
provider/resource_keycloak_identity_provider_token_exchange_scope_permission.go
Outdated
Show resolved
Hide resolved
provider/resource_keycloak_identity_provider_token_exchange_scope_permission.go
Outdated
Show resolved
Hide resolved
provider/resource_keycloak_identity_provider_token_exchange_scope_permission.go
Outdated
Show resolved
Hide resolved
provider/resource_keycloak_identity_provider_token_exchange_scope_permission.go
Outdated
Show resolved
Hide resolved
provider/resource_keycloak_identity_provider_token_exchange_scope_permission.go
Show resolved
Hide resolved
provider/resource_keycloak_identity_provider_token_exchange_scope_permission.go
Show resolved
Hide resolved
|
Nice work on this @tomrutsaert! I think it's pretty funny that the feature flag only toggles its visibility in the UI. We should probably just leave that toggle enabled for example purposes. |
…ope_permission.go Co-authored-by: Michael Parker <michael@parker.gg>
…on method + improved policy name creator logic
mrparkers
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resource to enable the token exchange idp permission and auto create of client policy
This is part of a preview keycloak feature. You need to enable this feature to be able to use this resource.
More information about enabling the preview feature can be found here: https://www.keycloak.org/docs/latest/securing_apps/index.html#_token-exchange
This implies that I enabled this feature in the docker-compose file.
This also implies that the tests will fail in CIRCLE-CI
@mrparkers What is your opinion on this?
Should I enable this preview feature in CIRCLE_CI or do I add a check in test_utils based on a env variable?
I did not see a way to detect if this feature is enabled via server_info, thus we can not use this server_info approach.