Support for flows, subflows and executions #215
Conversation
…data_source_keyc_realm
|
Thanks for re-opening this, I'll have some time later this week to review this again 😄 |
| "ssl_required": { | ||
| Type: schema.TypeString, | ||
| Computed: true, | ||
| }, | ||
|
|
There was a problem hiding this comment.
Changes in this file are not really related to the PR, but I saw they were missing, so I added them. see also #218
| return nil | ||
| } | ||
|
|
||
| func (keycloakClient *KeycloakClient) LowerAuthenticationExecutionPriority(realmId, id string) error { |
There was a problem hiding this comment.
are these two functions used? if not, how should users raise and lower the priority for executions?
There was a problem hiding this comment.
There are not used, but they do work.
I left in here in the case some one worked out a better solution, and could use these methods....
Should I remove them?
There was a problem hiding this comment.
No, I was just curious how the priority was determined, but then I realized in your example that you used depends_on in order to ensure subflows with higher priorities were created before subflows with lower priorities.
This approach makes sense, although it would be impossible to update this aftwards. But if that's good enough for you then I'm okay with this. I'm hoping that this is good enough for most users until Keycloak X is released, in which case I'll probably have to rewrite a lot of this provider anyways.
support for flows, subflows and executions
(+ added missing fields in data_source_keycloak_realm)
This are the changes form PR #138 + adaptations needed for keycloak 8.0.x
See comments in #138 for more info