Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* change ipwrap to ansible.utils.ipwrap #185

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

eRadical
Copy link
Collaborator

@eRadical eRadical commented Jan 9, 2024

Description

Changed to FQDN

Related Issue

Closes #183

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@eRadical eRadical requested a review from elcomtik January 9, 2024 13:58
@eRadical
Copy link
Collaborator Author

eRadical commented Jan 9, 2024

@elcomtik || @mrlesmithjr - should we bump up minimum Ansible req. w/ this change?
What are your thoughts?

@elcomtik
Copy link
Collaborator

elcomtik commented Jan 9, 2024

Yes, we should definitely bump minimum ansible version needed

@eRadical
Copy link
Collaborator Author

eRadical commented Jan 9, 2024

I was afraid of this answer as it begs a new question: to what version?

@eRadical
Copy link
Collaborator Author

eRadical commented Jan 9, 2024

Starting in Ansible 2.10, most modules live in collections
We have a requirement for Ansible 6.6.0 so we're covered w/ this.

ansible.utils.ipwrap filter - This filter plugin is part of the ansible.utils collection version 2.12.0.
^^^ It's this that I need to add and it's only one month old.

@eRadical
Copy link
Collaborator Author

eRadical commented Jan 9, 2024

Upon research:

  • we are ok w/ Ansible 6.6.0
  • bumped ansible-core to 2.13.9 from 2.13.7
  • enforced collection ansible.util to at least 2.12.0

@eRadical eRadical merged commit fd605ea into mrlesmithjr:master Jan 10, 2024
9 checks passed
@eRadical eRadical deleted the fix-ipwrap branch January 10, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warning about "ipwrap" module
2 participants