Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release new version to support Go 1.20 #70

Closed
Tracked by #134468
lcheylus opened this issue Jun 13, 2023 · 2 comments · Fixed by #72
Closed
Tracked by #134468

Release new version to support Go 1.20 #70

lcheylus opened this issue Jun 13, 2023 · 2 comments · Fixed by #72

Comments

@lcheylus
Copy link

I'm updating my OpenBSD port for doggo with the latest version (0.5.5). I'm using Go 1.20 to build my port (currently supported version on OpenBSD-current / future version 6.4).

But I have an error during my build with Go version 1.20 because github.com/lucas-clemente/quic-go module v0.31.1 (version required for doggo v0.5.5) is not supported:

$ go build
(...)
github.com/lucas-clemente/quic-go/internal/qtls
# github.com/lucas-clemente/quic-go/internal/qtls
../../../go/pkg/mod/github.com/lucas-clemente/quic-go@v0.31.1/internal/qtls/go120.go:5:13: cannot use "The version of quic-go you're using can't be built on Go 1.20 yet. For more details, please see https://github.com/lucas-clemente/quic-go/wiki/quic-go-and-Go-versions." (untyped string constant "The version of quic-go you're using can't be built on Go 1.20 yet. F...) as int value in variable declaration

The latest version v0.35.1 of quic-go module supports Go 1.20.

Please could you release a new version (0.5.6 ?) of doggo to support build with Go 1.20 ?
@stefanb stefanb mentioned this issue Jul 22, 2023
Merged
89 tasks
@stefanb
Copy link
Contributor

stefanb commented Jul 22, 2023 •
edited
Loading

Yesterday v0.37.0 of quic-go was released, supporting Go 1.20 and upcoming 1.21
See: https://github.com/quic-go/quic-go/releases/tag/v0.37.0

@stefanb stefanb mentioned this issue Jul 22, 2023
Merged
mr-karan pushed a commit that referenced this issue Jul 22, 2023
@stefanb @mr-karan
Migrate to github.com/quic-go/quic-go for Go 1.20 & 1.21
d181e06 
Migrate to github.com/quic-go/quic-go for Go 1.20 & 1.21

Use https://github.com/quic-go/quic-go/releases/tag/v0.37.0

Fixes #70
Closes #66
@lcheylus
Copy link
Author

Build OK for release 0.5.6 on OpenBSD/amd64 with Go v1.20 and with Go v1.21 adding commit 9818c32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support Go 1.20 & 1.21
2 participants
@stefanb @lcheylus