Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use Copy Reference #24

Merged
merged 1 commit into from
Sep 4, 2024
Merged

feat: Use Copy Reference #24

merged 1 commit into from
Sep 4, 2024

Conversation

BrandonStalnaker
Copy link
Contributor

Summary

  • These local properties should be copy references rather than the default of strong as best practice

Testing Plan

  • Tested in sample app on simulator

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@BrandonStalnaker BrandonStalnaker self-assigned this Aug 29, 2024
mmustafa-tse
mmustafa-tse approved these changes Aug 29, 2024
View reviewed changes
Copy link

@mmustafa-tse mmustafa-tse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

einsteinx2
einsteinx2 approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should prevent that reported crash, though it shouldn't have been happening in the first place...

In any case, there's no downsides to this and it's best practice, so LGTM

@BrandonStalnaker BrandonStalnaker merged commit 0d88d82 into development Sep 4, 2024
3 checks passed
@BrandonStalnaker BrandonStalnaker deleted the feat/SQDSDKS-6649-Copy-Reference-Over-Strong branch September 4, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@einsteinx2 einsteinx2 einsteinx2 approved these changes

@mmustafa-tse mmustafa-tse mmustafa-tse approved these changes

Assignees

@BrandonStalnaker BrandonStalnaker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrandonStalnaker @einsteinx2 @mmustafa-tse