This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Correct the keyboard layout when showing from the focus view. #3650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluemarvin
approved these changes
Jul 7, 2020
| @@ -972,31 +973,42 @@ private void handleDone() { | |||
| } | |||
| } | |||
|
|
|||
| private void handleModeChange() { | |||
| Keyboard current = mKeyboardView.getKeyboard(); | |||
| private void handleShowKeyboard(Keyboard aKeyboard) { | |||
| Keyboard alphabetic = mCurrentKeyboard.getAlphabeticKeyboard(); | |||
| Keyboard alphabetiCap = mCurrentKeyboard.getAlphabeticCapKeyboard(); | |||
There was a problem hiding this comment.
nit: Looks like alphabetiCap should be alphabeticCap. Can be addressed in follow up since it is preexisting.
|
Let's land this so I can create an rc5 and address any new issues in follow ups. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3640.